Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/34 introduce unit tests for generator #67

Merged
merged 26 commits into from
Nov 18, 2024
Merged

Feature/34 introduce unit tests for generator #67

merged 26 commits into from
Nov 18, 2024

Conversation

MobiTikula
Copy link
Collaborator

@MobiTikula MobiTikula commented Nov 13, 2024 •
edited by miroslavpojer
Loading

Unit tests using Pytest for generator.py and main.py.

Release Notes:

  • Implemented unit tests using Pytest for generator.py and main.py (project code-cov at (96 %).

Closes #34

@MobiTikula
Introducing TOPIC term as a replacement for LABEL.
bf8b45d
@MobiTikula
Introducing new action input GROUP_OUTPUT_BY_TOPICS.
164128c
@MobiTikula
Revert "Introducing TOPIC term as a replacement for LABEL."
720e4ee 
This reverts commit bf8b45d.
@MobiTikula
Implementing logic, for having Topic structured output.
358f62e
@MobiTikula
Logic for Topics without structured output.
5fa1088
@MobiTikula
Logic for grouping issues by Topics.
592fce1
@MobiTikula
Final touches.
311c189
@MobiTikula
Update of README.md file with new feature of grouping issues by topics.
59bf373
@MobiTikula
Pylint touches.
656c21e
@MobiTikula
Review comments added for README.md
f62aa4c
@MobiTikula
Review comments added for consolidated_issue.py.
b6088b4
@MobiTikula
Logic for handling more than one Topic assigned to an Issue.
ecaffe0
@MobiTikula
Test for added new logic.
dadffcc
@MobiTikula
Black formatting.
b622d5d
@MobiTikula
UnitTests using Pytest for main.py
87e3966
@MobiTikula
Unit tests using pytest for generator.py.
3c65059
@MobiTikula
Updated logic for having more than one topic linked to issue.
44adc7c
@MobiTikula
Merge branch 'refs/heads/feature/52-Introduce-Topics' into feature/34…
d9f84db 
…-Introduce-Unit-Tests-For-Generator
@MobiTikula
All unit tests for generator script.
e34a969
@MobiTikula
Design touches for unit tests.
811becf
@MobiTikula MobiTikula added the enhancement New feature or request label Nov 13, 2024
@MobiTikula MobiTikula self-assigned this Nov 13, 2024
@MobiTikula MobiTikula linked an issue Nov 13, 2024 that may be closed by this pull request
Introduce Unit Tests and Code Coverage #34
Closed
miroslavpojer
miroslavpojer reviewed Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • local run
  • unit test run
    Missing tests:
  • action_input: I would cover three static methods by tests to check default values expected by documentation.
  • github_projects: I would propose new issue to implement Integration test - testing current branch code for mining with full features enabled (result can be empty, it depends - it is not exact counting test)

pyproject.toml Outdated Show resolved Hide resolved
tests/test_generator.py Outdated Show resolved Hide resolved
tests/test_generator.py Show resolved Hide resolved
@MobiTikula
Copy link
Collaborator Author

Added suggested Action Inputs tests for testing the default values. Ready for another review.

miroslavpojer
miroslavpojer reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review
  • local run
  • unit test run
  • code coverage check

@MobiTikula MobiTikula merged commit 51b688b into master Nov 18, 2024
4 checks passed
@MobiTikula MobiTikula deleted the feature/34-Introduce-Unit-Tests-For-Generator branch November 18, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

Assignees

@MobiTikula MobiTikula

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Unit Tests and Code Coverage
2 participants
@MobiTikula @miroslavpojer